Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-4149] require login to deploy named templates #4450

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

masenf
Copy link
Collaborator

@masenf masenf commented Nov 27, 2024

  • require reflex loginv2 authentication and valid auth token to deploy a reflex-owned template
  • github templates can be deployed without logging in

@masenf masenf force-pushed the masenf/template-login branch from b158aeb to 07dfc36 Compare November 28, 2024 00:15
@masenf masenf changed the title [WiP] template login [ENG-4149] require login to deploy named templates Nov 28, 2024
Copy link

linear bot commented Nov 28, 2024

Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working well for me

@masenf masenf marked this pull request as ready for review December 5, 2024 02:15
@masenf masenf merged commit a894f21 into main Dec 5, 2024
33 checks passed
@masenf masenf deleted the masenf/template-login branch December 5, 2024 02:15
masenf added a commit that referenced this pull request Dec 5, 2024
* integration_tests.yml: init masenf/rx_shout as a template

fix test

* [ENG-4149] require login to deploy template

* Send loginv2 telemetry event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants